Bug 131739 - [New Multicolumn] Selection in gaps and blank spots doesn't work.
Summary: [New Multicolumn] Selection in gaps and blank spots doesn't work.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-16 10:13 PDT by Dave Hyatt
Modified: 2014-04-16 17:28 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.26 KB, patch)
2014-04-16 16:47 PDT, Dave Hyatt 		enrica: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2014-04-16 10:13:38 PDT 
The selection for multi-column layout breaks down when in the gaps or blank spots of the block. positionForPoint has code to adjust the point to the correct column for the old multi-column code, but it has not been patched yet for the new multi-column code.
Comment 1 Dave Hyatt 2014-04-16 16:47:54 PDT 
Created attachment 229498 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-16 16:50:46 PDT 
Attachment 229498 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:889:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:918:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:954:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Enrica Casucci 2014-04-16 16:53:29 PDT 
Comment on attachment 229498 [details]
Patch

Looks good to me.
Comment 4 Dave Hyatt 2014-04-16 17:28:08 PDT 
Landed in r167404.