Bug 131738 - [New Multicolumn] columnTranslationForOffset is not column-span-aware
Summary: [New Multicolumn] columnTranslationForOffset is not column-span-aware
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-16 10:11 PDT by Dave Hyatt
Modified: 2014-04-22 13:06 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.94 KB, patch)
2014-04-22 13:00 PDT, Dave Hyatt 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2014-04-16 10:11:01 PDT 
columnTranslationForOffset needs to work with column-span and with multiple column sets. Right now it only works if the column set is the first one. A column set after a span won't add in its offset like it should.
Comment 1 Radar WebKit Bug Importer 2014-04-17 23:13:30 PDT 
<rdar://problem/16656294>
Comment 2 Dave Hyatt 2014-04-21 13:43:02 PDT 
This does not block turning the new columns on.
Comment 3 Dave Hyatt 2014-04-22 13:00:48 PDT 
Created attachment 229909 [details]
Patch

Since I'm so close to turning new columns on, this is covered by tests that will be enabled when the flag is flipped.
Comment 4 Dave Hyatt 2014-04-22 13:06:09 PDT 
Fixed in r167677.