WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 131733
prepare-ChangeLog reports as deleted methods that has not been removed
https://bugs.webkit.org/show_bug.cgi?id=131733
Summary
prepare-ChangeLog reports as deleted methods that has not been removed
Manuel Rego Casasnovas
Reported
2014-04-16 07:54:27 PDT
After the changes introduced in
r166156
prepare-ChangeLog is marking as deleted some methods that have not been modified at all. Take a look to the patch attached to
bug #131732
(
https://bug-131732-attachments.webkit.org/attachment.cgi?id=229443
). prepare-ChangeLog is marking as deleted several methods (logicalContentHeightForChild, minContentForChild, etc.) that are not removed in the patch actually they're not even modified.
Attachments
proposed patch
(1.32 KB, patch)
2014-04-24 00:46 PDT
,
László Langó
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
László Langó
Comment 1
2014-04-24 00:46:45 PDT
Created
attachment 230058
[details]
proposed patch
Manuel Rego Casasnovas
Comment 2
2014-04-24 00:55:34 PDT
Comment on
attachment 230058
[details]
proposed patch I've tested it and it works properly for my patch. Thanks.
WebKit Commit Bot
Comment 3
2014-04-24 01:55:49 PDT
Comment on
attachment 230058
[details]
proposed patch Clearing flags on attachment: 230058 Committed
r167753
: <
http://trac.webkit.org/changeset/167753
>
WebKit Commit Bot
Comment 4
2014-04-24 01:55:52 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug