Bug 131733 - prepare-ChangeLog reports as deleted methods that has not been removed
Summary: prepare-ChangeLog reports as deleted methods that has not been removed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: László Langó
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-16 07:54 PDT by Manuel Rego Casasnovas
Modified: 2014-04-24 01:55 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (1.32 KB, patch)
2014-04-24 00:46 PDT, László Langó 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2014-04-16 07:54:27 PDT 
After the changes introduced in r166156 prepare-ChangeLog is marking as deleted some methods that have not been modified at all.

Take a look to the patch attached to bug #131732 (https://bug-131732-attachments.webkit.org/attachment.cgi?id=229443). prepare-ChangeLog is marking as deleted several methods (logicalContentHeightForChild, minContentForChild, etc.) that are not removed in the patch actually they're not even modified.
Comment 1 László Langó 2014-04-24 00:46:45 PDT 
Created attachment 230058 [details]
proposed patch
Comment 2 Manuel Rego Casasnovas 2014-04-24 00:55:34 PDT 
Comment on attachment 230058 [details]
proposed patch

I've tested it and it works properly for my patch. Thanks.
Comment 3 WebKit Commit Bot 2014-04-24 01:55:49 PDT 
Comment on attachment 230058 [details]
proposed patch

Clearing flags on attachment: 230058

Committed r167753: <http://trac.webkit.org/changeset/167753>
Comment 4 WebKit Commit Bot 2014-04-24 01:55:52 PDT 
All reviewed patches have been landed.  Closing bug.