Bug 131728 – [WebKit] Cleanup the build from uninitialized variable in JavaScriptCore

• Status: VERIFIED
• Resolution: FIXED
• Component: JavaScriptCore

[Shivakumar J M]

Found uninitialized variable used in JavaScriptCore/runtime/JSObject.cpp during webkit-efl port build.

/home/shiva.jm/webkit-git/svngit/WebKit/Source/JavaScriptCore/runtime/JSObject.cpp:824:17: warning: ‘v’ is used uninitialized in this function [-Wuninitialized]
         JSValue v;

[Mark Hahnenberg]

(In reply to comment #0)
> Found uninitialized variable used in JavaScriptCore/runtime/JSObject.cpp during webkit-efl port build.
> 
> /home/shiva.jm/webkit-git/svngit/WebKit/Source/JavaScriptCore/runtime/JSObject.cpp:824:17: warning: ‘v’ is used uninitialized in this function [-Wuninitialized]
>          JSValue v;

This seems wrong. JSValue has a default constructor, so it's not uninitialized. Sounds like your compiler is confused.

One thing that might be worth fixing which would incidentally shut the compiler up is do add a default case with a RELEASE_ASSERT. If we don't hit a case in the switch statement then we have a debug ASSERT that will fire. Might as well add the release assert inside the branch that we'll never take.

[Mark Hahnenberg]

Created attachment 229453 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 229453 [details]
Patch

Clearing flags on attachment: 229453

Committed r167364: <http://trac.webkit.org/changeset/167364>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Shivakumar J M]

Bug is fixed tested in version 167979.