Bug 131725 - REGRESSION(r166779): [GTK] Printing doesn't work since r166779
Summary: REGRESSION(r166779): [GTK] Printing doesn't work since r166779
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2014-04-16 02:41 PDT by Carlos Garcia Campos
Modified: 2014-04-16 03:20 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.07 KB, patch)
2014-04-16 02:44 PDT, Carlos Garcia Campos 		pnormand: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-04-16 02:41:50 PDT 
Printing doesn't work since r166779, but that revision was not the one introduced the problem, but just revealing it. The problem is that due to some typos in the makefiles, we are always building with printing disabled.

$ grep GTK_UNIX_PRINTING cmakeconfig.h 
#define HAVE_GTK_UNIX_PRINTING 0
Comment 1 Carlos Garcia Campos 2014-04-16 02:44:37 PDT 
Created attachment 229435 [details]
Patch
Comment 2 Philippe Normand 2014-04-16 03:17:12 PDT 
Comment on attachment 229435 [details]
Patch

Nice one Carlos :)
Comment 3 Carlos Garcia Campos 2014-04-16 03:20:33 PDT 
Committed r167344: <http://trac.webkit.org/changeset/167344>