Bug 131722 - [iOS][WK2] Fix annoying scrolling bugs
Summary: [iOS][WK2] Fix annoying scrolling bugs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-15 22:15 PDT by Benjamin Poulain
Modified: 2014-04-16 20:27 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.97 KB, patch)
2014-04-15 22:17 PDT, Benjamin Poulain 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-04-15 22:15:01 PDT 
[iOS][WK2] Fix annoying scrolling bugs
Comment 1 Benjamin Poulain 2014-04-15 22:17:42 PDT 
Created attachment 229430 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-04-15 23:01:29 PDT 
Comment on attachment 229430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229430&action=review

Thanks for fixing!

> Source/WebCore/ChangeLog:11
> +        keep changing the scroll position to incorrect values.

Why does it compute incorrect values?
Comment 3 Simon Fraser (smfr) 2014-04-16 10:43:34 PDT 
Comment on attachment 229430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229430&action=review

> Source/WebCore/platform/ScrollView.cpp:545
> +#if PLATFORM(IOS)
> +    UNUSED_PARAM(desiredOffset);
> +    return;
> +#else

Afterthought: should this be if delegatesScrolling() rather than an #ifdef?
Comment 4 Benjamin Poulain 2014-04-16 20:27:23 PDT 
Committed r167411: <http://trac.webkit.org/changeset/167411>