Bug 131718 - [Cocoa] Add a form delegate method corresponding to willSubmitForm
Summary: [Cocoa] Add a form delegate method corresponding to willSubmitForm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-15 17:53 PDT by mitz
Modified: 2014-04-15 22:17 PDT (History)
0 users

See Also:

Attachments
Add -_webView:willSubmitFormValues:userObject:submissionHandler: (11.37 KB, patch)
2014-04-15 17:58 PDT, mitz 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-04-15 17:53:23 PDT 
[Cocoa] Add a form delegate method corresponding to willSubmitForm
Comment 1 mitz 2014-04-15 17:58:39 PDT 
Created attachment 229422 [details]
Add -_webView:willSubmitFormValues:userObject:submissionHandler:
Comment 2 Joseph Pecoraro 2014-04-15 18:31:25 PDT 
Comment on attachment 229422 [details]
Add -_webView:willSubmitFormValues:userObject:submissionHandler:

View in context: https://bugs.webkit.org/attachment.cgi?id=229422&action=review

Some drive-by nit comments.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1192
> +    class FormClient : public API::FormClient {

Can we make this final?

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:426
> +            userData = API::Data::createWithoutCopying((const unsigned char*)[data bytes], [data length], releaseNSData, data.leakRef()).leakRef();

static_cast?
Comment 3 mitz 2014-04-15 22:17:11 PDT 
Committed <http://trac.webkit.org/r167343>.