RESOLVED FIXED 131718
[Cocoa] Add a form delegate method corresponding to willSubmitForm 
https://bugs.webkit.org/show_bug.cgi?id=131718
Summary [Cocoa] Add a form delegate method corresponding to willSubmitForm
mitz
Reported 2014-04-15 17:53:23 PDT
[Cocoa] Add a form delegate method corresponding to willSubmitForm
Attachments
Add -_webView:willSubmitFormValues:userObject:submissionHandler: (11.37 KB, patch)
2014-04-15 17:58 PDT, mitz 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-04-15 17:58:39 PDT
Created attachment 229422 [details] Add -_webView:willSubmitFormValues:userObject:submissionHandler:
Joseph Pecoraro
Comment 2 2014-04-15 18:31:25 PDT
Comment on attachment 229422 [details] Add -_webView:willSubmitFormValues:userObject:submissionHandler: View in context: https://bugs.webkit.org/attachment.cgi?id=229422&action=review Some drive-by nit comments. > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1192 > + class FormClient : public API::FormClient { Can we make this final? > Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:426 > + userData = API::Data::createWithoutCopying((const unsigned char*)[data bytes], [data length], releaseNSData, data.leakRef()).leakRef(); static_cast?
mitz
Comment 3 2014-04-15 22:17:11 PDT
Committed <http://trac.webkit.org/r167343>.
Note You need to log in before you can comment on or make changes to this bug.