Bug 131714 - Introduce API::FormClient
Summary: Introduce API::FormClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-15 15:45 PDT by mitz
Modified: 2014-04-15 16:06 PDT (History)
0 users

See Also:

Attachments
Patch (14.25 KB, patch)
2014-04-15 15:51 PDT, mitz 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-04-15 15:45:14 PDT 
Introduce API::FormClient
Comment 1 mitz 2014-04-15 15:51:25 PDT 
Created attachment 229412 [details]
Patch
Comment 2 Tim Horton 2014-04-15 16:00:19 PDT 
Comment on attachment 229412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229412&action=review

> Source/WebKit2/UIProcess/API/APIFormClient.h:45
> +    virtual bool willSubmitForm(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, WebKit::WebFrameProxy* sourceFrame, const Vector<std::pair<WTF::String, WTF::String>>& textFieldValues, API::Object* userData, WebKit::WebFormSubmissionListenerProxy*)

do you need the WTF::s here?
Comment 3 mitz 2014-04-15 16:06:07 PDT 
(In reply to comment #2)
> (From update of attachment 229412 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=229412&action=review
> 
> > Source/WebKit2/UIProcess/API/APIFormClient.h:45
> > +    virtual bool willSubmitForm(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, WebKit::WebFrameProxy* sourceFrame, const Vector<std::pair<WTF::String, WTF::String>>& textFieldValues, API::Object* userData, WebKit::WebFormSubmissionListenerProxy*)
> 
> do you need the WTF::s here?

No!

Committed <http://trac.webkit.org/r167330>.