RESOLVED FIXED 131714
Introduce API::FormClient 
https://bugs.webkit.org/show_bug.cgi?id=131714
Summary Introduce API::FormClient
mitz
Reported 2014-04-15 15:45:14 PDT
Introduce API::FormClient
Attachments
Patch (14.25 KB, patch)
2014-04-15 15:51 PDT, mitz 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-04-15 15:51:25 PDT
Created attachment 229412 [details] Patch
Tim Horton
Comment 2 2014-04-15 16:00:19 PDT
Comment on attachment 229412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229412&action=review > Source/WebKit2/UIProcess/API/APIFormClient.h:45 > + virtual bool willSubmitForm(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, WebKit::WebFrameProxy* sourceFrame, const Vector<std::pair<WTF::String, WTF::String>>& textFieldValues, API::Object* userData, WebKit::WebFormSubmissionListenerProxy*) do you need the WTF::s here?
mitz
Comment 3 2014-04-15 16:06:07 PDT
(In reply to comment #2) > (From update of attachment 229412 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=229412&action=review > > > Source/WebKit2/UIProcess/API/APIFormClient.h:45 > > + virtual bool willSubmitForm(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, WebKit::WebFrameProxy* sourceFrame, const Vector<std::pair<WTF::String, WTF::String>>& textFieldValues, API::Object* userData, WebKit::WebFormSubmissionListenerProxy*) > > do you need the WTF::s here? No! Committed <http://trac.webkit.org/r167330>.
Note You need to log in before you can comment on or make changes to this bug.