Bug 131708 - check-webkit-style doesn't check code style in .mm or .m files
Summary: check-webkit-style doesn't check code style in .mm or .m files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-15 15:11 PDT by Tim Horton
Modified: 2014-04-16 10:18 PDT (History)
9 users (show)

See Also:

Attachments
patch (6.18 KB, patch)
2014-04-15 15:40 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
fix the test too (7.05 KB, patch)
2014-04-15 15:43 PDT, Tim Horton 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-04-15 15:11:52 PDT 
They're treated as plaintext, so we do check indentation and stuff, but do not apply code rules!

Additionally, the style checker isn't quite smart enough to handle ObjC yet, so we have to adjust some of the rules a bit.
Comment 1 Tim Horton 2014-04-15 15:12:29 PDT 
Most stuff already works because we frequently check style of ObjC headers.
Comment 2 Tim Horton 2014-04-15 15:40:17 PDT 
Created attachment 229410 [details]
patch

This covers all of the obvious false positives in a few ObjC(++) files I tested, but I'm sure there will be more, which we can fix as they come up.
Comment 3 Tim Horton 2014-04-15 15:43:02 PDT 
Created attachment 229411 [details]
fix the test too
Comment 4 Tim Horton 2014-04-16 10:18:49 PDT 
http://trac.webkit.org/changeset/167350