Bug 131706 - PDFPlugin style fixes
Summary: PDFPlugin style fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-15 15:07 PDT by Tim Horton
Modified: 2014-04-16 10:56 PDT (History)
3 users (show)

See Also:

Attachments
patch (12.65 KB, patch)
2014-04-15 15:08 PDT, Tim Horton 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-04-15 15:07:33 PDT 
While working on getting the style checker to check Objective-C source files, I ran through all of the errors in PDFPlugin.mm and fixed the ones that were broken in the style-checker there, and the ones that were broken in PDFPlugin here. No reason to throw away good style fixes, so let's land them.
Comment 1 Tim Horton 2014-04-15 15:08:39 PDT 
Created attachment 229407 [details]
patch
Comment 2 WebKit Commit Bot 2014-04-15 15:10:41 PDT 
Attachment 229407 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-04-16 10:56:01 PDT 
http://trac.webkit.org/changeset/167357