WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
Bug 131689
Turn NodeResultMask in NodeFlags into something that more directly conveys the representation
https://bugs.webkit.org/show_bug.cgi?id=131689
Summary
Turn NodeResultMask in NodeFlags into something that more directly conveys th...
Filip Pizlo
Reported
2014-04-15 12:32:10 PDT
Both UseKind and NodeResultMask may convey representation. The possible representations are Value, Double, and Int52. We should really have a separate enum for Representation. NodeResultMask could still internally use the same format as it does now. Then we could also have the notion of "guaranteeing" that a node returns an Int32, Number, or Boolean - but we should encapsulate this somehow and separate it from NodeResultMask. That would allow us to get rid of horrible things like canonicalResultRepresentation().
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug