Bug 131689 - Turn NodeResultMask in NodeFlags into something that more directly conveys the representation
Summary: Turn NodeResultMask in NodeFlags into something that more directly conveys th...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 131423
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-15 12:32 PDT by Filip Pizlo
Modified: 2014-04-15 12:32 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-04-15 12:32:10 PDT 
Both UseKind and NodeResultMask may convey representation.  The possible representations are Value, Double, and Int52.  We should really have a separate enum for Representation.  NodeResultMask could still internally use the same format as it does now.  Then we could also have the notion of "guaranteeing" that a node returns an Int32, Number, or Boolean - but we should encapsulate this somehow and separate it from NodeResultMask.  That would allow us to get rid of horrible things like canonicalResultRepresentation().