Bug 131663 - [EFL][WK2] Pass Mouse movement data to WebMouseEvent
Summary: [EFL][WK2] Pass Mouse movement data to WebMouseEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-14 22:25 PDT by Jinwoo Song
Modified: 2014-04-15 06:01 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.68 KB, patch)
2014-04-14 22:27 PDT, Jinwoo Song
no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2014-04-14 22:30 PDT, Jinwoo Song
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2014-04-14 22:25:20 PDT
Currently mouse movement data are not passed to WebMouseEvent. Instead, they are set to 0 as default.
EFL port needs to send the deltaX and deltaY for PointerLock API which will be implemented later.
Comment 1 Jinwoo Song 2014-04-14 22:27:03 PDT
Created attachment 229347 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-14 22:28:53 PDT
Attachment 229347 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit2/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jinwoo Song 2014-04-14 22:30:59 PDT
Created attachment 229348 [details]
Patch
Comment 4 Gyuyoung Kim 2014-04-14 23:07:38 PDT
Comment on attachment 229348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229348&action=review

> Source/WebKit2/Shared/efl/WebEventFactory.cpp:138
> +        (event->cur.canvas.x - event->prev.canvas.x) /* deltaX */,

There are three createWebMouseEvent there. Don't you need to change all those functions together ?
Comment 5 Gyuyoung Kim 2014-04-14 23:08:09 PDT
CC'ing Eunmi
Comment 6 Jinwoo Song 2014-04-15 02:22:26 PDT
Comment on attachment 229348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229348&action=review

>> Source/WebKit2/Shared/efl/WebEventFactory.cpp:138
>> +        (event->cur.canvas.x - event->prev.canvas.x) /* deltaX */,
> 
> There are three createWebMouseEvent there. Don't you need to change all those functions together ?

In case of Evas_Event_Mouse_Down and Evas_Event_Mouse_Up, there is no movement data so we can set the delta values as 0.
Comment 7 Gyuyoung Kim 2014-04-15 03:14:26 PDT
Comment on attachment 229348 [details]
Patch

Thank you for reply. LGTM.
Comment 8 WebKit Commit Bot 2014-04-15 06:01:30 PDT
Comment on attachment 229348 [details]
Patch

Clearing flags on attachment: 229348

Committed r167305: <http://trac.webkit.org/changeset/167305>
Comment 9 WebKit Commit Bot 2014-04-15 06:01:40 PDT
All reviewed patches have been landed.  Closing bug.