Currently mouse movement data are not passed to WebMouseEvent. Instead, they are set to 0 as default. EFL port needs to send the deltaX and deltaY for PointerLock API which will be implemented later.
Created attachment 229347 [details] Patch
Attachment 229347 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebKit2/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 229348 [details] Patch
Comment on attachment 229348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229348&action=review > Source/WebKit2/Shared/efl/WebEventFactory.cpp:138 > + (event->cur.canvas.x - event->prev.canvas.x) /* deltaX */, There are three createWebMouseEvent there. Don't you need to change all those functions together ?
CC'ing Eunmi
Comment on attachment 229348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229348&action=review >> Source/WebKit2/Shared/efl/WebEventFactory.cpp:138 >> + (event->cur.canvas.x - event->prev.canvas.x) /* deltaX */, > > There are three createWebMouseEvent there. Don't you need to change all those functions together ? In case of Evas_Event_Mouse_Down and Evas_Event_Mouse_Up, there is no movement data so we can set the delta values as 0.
Comment on attachment 229348 [details] Patch Thank you for reply. LGTM.
Comment on attachment 229348 [details] Patch Clearing flags on attachment: 229348 Committed r167305: <http://trac.webkit.org/changeset/167305>
All reviewed patches have been landed. Closing bug.