Bug 131655 - [EFL][WK2] Use double tap gesture only if page is scalable.
Summary: [EFL][WK2] Use double tap gesture only if page is scalable.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eunmi Lee
URL:
Keywords:
Depends on: 107631
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-14 18:21 PDT by Eunmi Lee
Modified: 2017-03-11 10:33 PST (History)
7 users (show)

See Also:

Attachments
Patch (5.47 KB, patch)
2014-04-14 18:29 PDT, Eunmi Lee 		no flags Details | Formatted Diff | Diff
Patch (5.48 KB, patch)
2014-04-20 22:06 PDT, Eunmi Lee 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eunmi Lee 2014-04-14 18:21:32 PDT 
Double tap gesture is used to scale page, so it is not necessary if page is not scalable.
Comment 1 Eunmi Lee 2014-04-14 18:29:31 PDT 
Created attachment 229332 [details]
Patch
Comment 2 Jinwoo Song 2014-04-15 02:34:11 PDT 
Comment on attachment 229332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229332&action=review

> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:536
> +        m_doubleTapTimer = 0;

s/0/nullptr
Comment 3 Eunmi Lee 2014-04-20 21:51:26 PDT 
Comment on attachment 229332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229332&action=review

>> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:536
>> +        m_doubleTapTimer = 0;
> 
> s/0/nullptr

thanks, I will update patch again :)
Comment 4 Eunmi Lee 2014-04-20 22:06:21 PDT 
Created attachment 229785 [details]
Patch
Comment 5 Michael Catanzaro 2017-03-11 10:33:49 PST 
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.