Bug 131638 - [iOS][WK2] Change the SPI used when starting the rotation animation
Summary: [iOS][WK2] Change the SPI used when starting the rotation animation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-14 15:15 PDT by Benjamin Poulain
Modified: 2014-04-14 15:39 PDT (History)
0 users

See Also:


Attachments
Patch (7.99 KB, patch)
2014-04-14 15:15 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (8.02 KB, patch)
2014-04-14 15:28 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-04-14 15:15:07 PDT
[iOS][WK2] Change the SPI used when starting the rotation animation
Comment 1 Benjamin Poulain 2014-04-14 15:15:34 PDT
Created attachment 229309 [details]
Patch
Comment 2 Ian Henderson 2014-04-14 15:18:17 PDT
Comment on attachment 229309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229309&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:111
> +- (void)_beginAnimatedResize:(void (^)(void))updateBlock;

I think the argument should be called out somehow in the selector name.  E.g.
- (void)_beginAnimatedResizeWithUpdates:(void (^)(void))updateBlock;
Everything looks good to me otherwise!
Comment 3 Benjamin Poulain 2014-04-14 15:28:53 PDT
Created attachment 229311 [details]
Patch
Comment 4 Benjamin Poulain 2014-04-14 15:39:40 PDT
Comment on attachment 229311 [details]
Patch

Clearing flags on attachment: 229311

Committed r167274: <http://trac.webkit.org/changeset/167274>
Comment 5 Benjamin Poulain 2014-04-14 15:39:42 PDT
All reviewed patches have been landed.  Closing bug.