Bug 131632 - RenderLayerCompositor's m_layerForOverhangAreas should be offset by the topContentInset
Summary: RenderLayerCompositor's m_layerForOverhangAreas should be offset by the topCo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-14 14:09 PDT by Beth Dakin
Modified: 2014-04-14 14:49 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2014-04-14 14:16 PDT, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-04-14 14:09:35 PDT 
RenderLayerCompositor's m_layerForOverhangAreas should be offset by the topContentInset.

<rdar://problem/16609602>
Comment 1 Beth Dakin 2014-04-14 14:16:03 PDT 
Created attachment 229304 [details]
Patch
Comment 2 Tim Horton 2014-04-14 14:32:16 PDT 
Comment on attachment 229304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229304&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:3007
> +            m_layerForOverhangAreas->setPosition(FloatPoint(0, m_renderView.frameView().topContentInset()));

should we shrink it by topContentInset?
Comment 3 Beth Dakin 2014-04-14 14:49:21 PDT 
(In reply to comment #2)
> (From update of attachment 229304 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=229304&action=review
> 
> > Source/WebCore/rendering/RenderLayerCompositor.cpp:3007
> > +            m_layerForOverhangAreas->setPosition(FloatPoint(0, m_renderView.frameView().topContentInset()));
> 
> should we shrink it by topContentInset?

We should! Fixed that.

http://trac.webkit.org/changeset/167270