Bug 131626 - Eliminate CachedFrame::m_mousePressNode
Summary: Eliminate CachedFrame::m_mousePressNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-14 11:26 PDT by Alexey Proskuryakov
Modified: 2014-04-14 14:24 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (4.98 KB, patch)
2014-04-14 11:31 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-04-14 11:26:56 PDT 
It doesn't make sense to preserve EventHandler::m_mousePressNode in a cached frame (and we don't preserve EventHandler::m_mousePressed anyway, potentially breaking EventHandler invariants).

How m_mousePressNode got into CachedFrame was by mechanically combining PageState and PageCache in r20837.
Comment 1 Alexey Proskuryakov 2014-04-14 11:31:34 PDT 
Created attachment 229294 [details]
proposed patch
Comment 2 WebKit Commit Bot 2014-04-14 14:24:31 PDT 
Comment on attachment 229294 [details]
proposed patch

Clearing flags on attachment: 229294

Committed r167267: <http://trac.webkit.org/changeset/167267>
Comment 3 WebKit Commit Bot 2014-04-14 14:24:33 PDT 
All reviewed patches have been landed.  Closing bug.