Bug 131614 - [WinCairo][cURL] Build fix for WinCairo with USE(CURL).
Summary: [WinCairo][cURL] Build fix for WinCairo with USE(CURL).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-14 07:13 PDT by Daewoong Jang
Modified: 2014-04-16 10:24 PDT (History)
2 users (show)

See Also:

Attachments
WinCairo build fix. (3.40 KB, patch)
2014-04-14 07:21 PDT, Daewoong Jang 		bfulgham: review+
bfulgham: commit-queue+
Details | Formatted Diff | Diff
Updated patch (3.20 KB, patch)
2014-04-16 09:44 PDT, Daewoong Jang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daewoong Jang 2014-04-14 07:13:02 PDT 
1. While building WinCairo with USE(CURL) instead of USE(SOUP), the compiler experiences errors.
2. cURL's cache system crashes during startup due to use of ascii string without ending NULL.
Comment 1 Daewoong Jang 2014-04-14 07:21:45 PDT 
Created attachment 229282 [details]
WinCairo build fix.
Comment 2 Daewoong Jang 2014-04-16 09:44:11 PDT 
Created attachment 229450 [details]
Updated patch
Comment 3 Brent Fulgham 2014-04-16 09:44:31 PDT 
Comment on attachment 229282 [details]
WinCairo build fix.

r=me
Comment 4 Brent Fulgham 2014-04-16 09:47:12 PDT 
Comment on attachment 229450 [details]
Updated patch

r=me
Comment 5 WebKit Commit Bot 2014-04-16 10:24:37 PDT 
Comment on attachment 229450 [details]
Updated patch

Clearing flags on attachment: 229450

Committed r167352: <http://trac.webkit.org/changeset/167352>
Comment 6 WebKit Commit Bot 2014-04-16 10:24:39 PDT 
All reviewed patches have been landed.  Closing bug.