Bug 131611 - Make WK(Web)View magnification setters actually use view-relative positions
Summary: Make WK(Web)View magnification setters actually use view-relative positions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-14 02:58 PDT by Tim Horton
Modified: 2014-04-14 10:28 PDT (History)
2 users (show)

See Also:


Attachments
patch (5.68 KB, patch)
2014-04-14 03:05 PDT, Tim Horton
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-04-14 02:58:04 PDT
WKWebView/WKView's setMagnification: and setMagnification:centeredAtPoint: both expose the somewhat bizarre but widespread notion of a scale "origin", which really just translates into the scroll position post-scale. We intended for setMagnification: and setMagnification:centeredAtPoint: to use view-relative points (and points within the view instead of (negative) scroll position) to center the zoom, as those make much more sense as exposed API.

<rdar://problem/15965239>
Comment 1 Tim Horton 2014-04-14 03:05:37 PDT
Created attachment 229276 [details]
patch
Comment 2 Tim Horton 2014-04-14 10:28:39 PDT
http://trac.webkit.org/changeset/167253