Bug 131608 – [sh4] SubImmediates can be used in sh4 LLINT

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Julien Brianceau]

SubImmediates can be used with sh4 const pool, so the sh4 arch can share the arm path for setEntryAddress.

This will reduce architecture specific code and lead to a more optimal implementation for sh4.

[Julien Brianceau]

Created attachment 229272 [details]
Allow use of SubImmediates in sh4 const pool in LLINT.

[Mark Lam]

Comment on attachment 229272 [details]
Allow use of SubImmediates in sh4 const pool in LLINT.

View in context: https://bugs.webkit.org/attachment.cgi?id=229272&action=review

r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:747
> +        if SH4
> +            flushcp # Force constant pool flush to avoid "pcrel too far" link error.
> +        end

I'd be concerned if this proliferates.  Ideally, it's be great if the offline backend knows to call flushcp automatically when needed without the LLINT assembly having to explicitly call it like this.  For now, since there's is only this one use of flushcp (i.e. here), I'll let it go.

[Julien Brianceau]

Committed r167269: <http://trac.webkit.org/changeset/167269>