Bug 131580 – [iOS] Move QuickLookHandle from ResourceLoader to WebResourceLoader

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[iOS] Move QuickLookHandle from ResourceLoader to WebResourceLoader

[Andy Estes]

Created attachment 229196 [details]
Patch

[Darin Adler]

Comment on attachment 229196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229196&action=review

> Source/WebKit2/WebProcess/Network/WebResourceLoader.h:98
> +    OwnPtr<WebCore::QuickLookHandle> m_quickLookHandle;

Should use std::unique_ptr instead of OwnPtr, but I suppose that requires changing the QuickLookHandle class itself.

[WebKit Commit Bot]

Comment on attachment 229196 [details]
Patch

Rejecting attachment 229196 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 229196, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
.
Hunk #3 succeeded at 212 (offset 10 lines).
2 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/loader/ResourceLoader.h.rej
patching file Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp
patching file Source/WebKit2/WebProcess/Network/WebResourceLoader.h
patching file Source/WebKit2/WebProcess/ios/WebResourceLoaderIOS.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5905835817435136

[Andy Estes]

Committed r167188: <http://trac.webkit.org/changeset/167188>