Bug 131580 - [iOS] Move QuickLookHandle from ResourceLoader to WebResourceLoader
Summary: [iOS] Move QuickLookHandle from ResourceLoader to WebResourceLoader
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
Depends on:
Reported: 2014-04-11 20:34 PDT by Andy Estes
Modified: 2014-04-12 14:06 PDT (History)
2 users (show)

See Also:

Patch (7.38 KB, patch)
2014-04-11 20:46 PDT, Andy Estes
darin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2014-04-11 20:34:09 PDT
[iOS] Move QuickLookHandle from ResourceLoader to WebResourceLoader
Comment 1 Andy Estes 2014-04-11 20:46:36 PDT
Created attachment 229196 [details]
Comment 2 Darin Adler 2014-04-12 13:05:53 PDT
Comment on attachment 229196 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=229196&action=review

> Source/WebKit2/WebProcess/Network/WebResourceLoader.h:98
> +    OwnPtr<WebCore::QuickLookHandle> m_quickLookHandle;

Should use std::unique_ptr instead of OwnPtr, but I suppose that requires changing the QuickLookHandle class itself.
Comment 3 WebKit Commit Bot 2014-04-12 13:38:17 PDT
Comment on attachment 229196 [details]

Rejecting attachment 229196 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 229196, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
Hunk #3 succeeded at 212 (offset 10 lines).
2 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/loader/ResourceLoader.h.rej
patching file Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp
patching file Source/WebKit2/WebProcess/Network/WebResourceLoader.h
patching file Source/WebKit2/WebProcess/ios/WebResourceLoaderIOS.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5905835817435136
Comment 4 Andy Estes 2014-04-12 14:06:48 PDT
Committed r167188: <http://trac.webkit.org/changeset/167188>