Bug 131574 - Lots of compositing test failures after r167152
Summary: Lots of compositing test failures after r167152
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-11 16:57 PDT by Tim Horton
Modified: 2014-04-14 08:43 PDT (History)
8 users (show)

See Also:

Attachments
as-yet untested patch (2.34 KB, patch)
2014-04-11 16:58 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
patch (1.57 KB, patch)
2014-04-11 17:27 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
patch (3.16 KB, patch)
2014-04-11 17:49 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
part 2 (2.90 KB, patch)
2014-04-14 00:42 PDT, Tim Horton 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-04-11 16:57:28 PDT 
Because of the extra empty layer in the tree.
Comment 1 Tim Horton 2014-04-11 16:58:57 PDT 
Created attachment 229181 [details]
as-yet untested patch

waiting on a build at the moment
Comment 2 Tim Horton 2014-04-11 17:27:35 PDT 
Created attachment 229184 [details]
patch
Comment 3 Tim Horton 2014-04-11 17:49:06 PDT 
Created attachment 229188 [details]
patch
Comment 4 Tim Horton 2014-04-11 18:26:18 PDT 
http://trac.webkit.org/changeset/167177
Comment 5 Benjamin Poulain 2014-04-13 20:54:33 PDT 
The tree is still red, can you please have a look?
Comment 6 Tim Horton 2014-04-13 23:25:27 PDT 
Wat, fixed the majority but there's one left? That is bizarre... I will look right away.
Comment 7 Tim Horton 2014-04-14 00:13:18 PDT 
Reopening to fix the one remaining failure.
Comment 8 Tim Horton 2014-04-14 00:24:57 PDT 
If we have a layer, skip one of its children, then want its grandchildren listed in its children's place, we won't correctly skip any grandchildren that want skipping. This mechanism (my fault in the first place, from many months ago) is a bit flawed. Will fix.
Comment 9 Tim Horton 2014-04-14 00:42:33 PDT 
Created attachment 229268 [details]
part 2
Comment 10 Darin Adler 2014-04-14 08:36:22 PDT 
Comment on attachment 229268 [details]
part 2

View in context: https://bugs.webkit.org/attachment.cgi?id=229268&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:596
> +    for (size_t childIndex = 0; childIndex < children.size(); childIndex++) {
> +        GraphicsLayer* child = children[childIndex];

This should use a C++11 for loop:

    for (auto* child : children) {
Comment 11 Tim Horton 2014-04-14 08:43:10 PDT 
http://trac.webkit.org/changeset/167246