Bug 131572 - [CSS Shapes] Linking stylesheet instead of inline style definition has ruined ShapesRegions test
Summary: [CSS Shapes] Linking stylesheet instead of inline style definition has ruined...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks: 128188
  Show dependency tree / graph
 
Reported: 2014-04-11 16:23 PDT by Zoltan Horvath
Modified: 2014-04-15 10:52 PDT (History)
3 users (show)

See Also:

Attachments
Patch (18.13 KB, patch)
2014-04-11 16:36 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (710.51 KB, application/zip)
2014-04-11 17:28 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2014-04-11 16:23:40 PDT 
In r167022 I moved the common CSS selectors into RegionsShapes.css, then I linked it into the perf test files, but the measurement results dropped down from about 400ms to 10ms. I realized it's caused by the linked css rule, so I've put the selectors back into every test case, which fixes the test measurements.
Comment 1 Zoltan Horvath 2014-04-11 16:36:20 PDT 
Created attachment 229177 [details]
Patch
Comment 2 Build Bot 2014-04-11 17:28:38 PDT 
Comment on attachment 229177 [details]
Patch

Attachment 229177 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6490103438376960

New failing tests:
compositing/iframes/invisible-nested-iframe-hide.html
Comment 3 Build Bot 2014-04-11 17:28:40 PDT 
Created attachment 229185 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Rob Buis 2014-04-15 10:12:27 PDT 
Comment on attachment 229177 [details]
Patch

Looks good.
Comment 5 WebKit Commit Bot 2014-04-15 10:52:37 PDT 
Comment on attachment 229177 [details]
Patch

Clearing flags on attachment: 229177

Committed r167315: <http://trac.webkit.org/changeset/167315>
Comment 6 WebKit Commit Bot 2014-04-15 10:52:40 PDT 
All reviewed patches have been landed.  Closing bug.