Bug 131569 – [GTK] REGRESSION(167145): Many media tests fail

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

Looks like we need to pull in the localized string JavaScript file

[Brent Fulgham]

*** Bug 131570 has been marked as a duplicate of this bug. ***

[Martin Robinson]

Created attachment 229174 [details]
Patch

[Brent Fulgham]

I think we need the following changes:

1. Pull in the JS with the strings in it:

--- platform/gtk/RenderThemeGtk.cpp    (revision 167146)
+++ platform/gtk/RenderThemeGtk.cpp    (working copy)
@@ -763,6 +763,7 @@
 String RenderThemeGtk::mediaControlsScript()
 {
     StringBuilder scriptBuilder;
+    scriptBuilder.append(mediaControlsLocalizedStringsJavaScript, sizeof(mediaControlsLocalizedStringsJavaScript));
     scriptBuilder.append(mediaControlsAppleJavaScript, sizeof(mediaControlsAppleJavaScript));
     scriptBuilder.append(mediaControlsGtkJavaScript, sizeof(mediaControlsGtkJavaScript));
     return scriptBuilder.toString();

2. Treat mediaControlsLocalizedStrings as a USER_AGENT_SCRIPT:

--- PlatformGTK.cmake    (revision 167146)
+++ PlatformGTK.cmake    (working copy)
@@ -259,6 +259,7 @@
 )

 set(WebCore_USER_AGENT_SCRIPTS
+    ${WEBCORE_DIR}/English.lproj/mediaControlsLocalizedStrings.js
     ${WEBCORE_DIR}/Modules/mediacontrols/mediaControlsApple.js
     ${WEBCORE_DIR}/Modules/mediacontrols/mediaControlsGtk.js
 )

3. Make sure the mediaControlsLocalizedStrings.js file gets pulled into the UserAgentGeneratedScripts.cpp.

[Brent Fulgham]

Comment on attachment 229174 [details]
Patch

Yes -- this looks like what I was thinking.  r+ once you confirm the bots are happy.

[Martin Robinson]

Created attachment 229178 [details]
Patch

[Xabier Rodríguez Calvar]

*** Bug 131568 has been marked as a duplicate of this bug. ***

[Xabier Rodríguez Calvar]

Please, fix EFL too with a similar patch.

[Martin Robinson]

Committed r167170: <http://trac.webkit.org/changeset/167170>