Bug 131567 - Need WK2 API to disable rubber-banding
Summary: Need WK2 API to disable rubber-banding
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-11 15:52 PDT by Beth Dakin
Modified: 2014-04-11 16:52 PDT (History)
4 users (show)

See Also:

Attachments
Patch (15.13 KB, patch)
2014-04-11 15:57 PDT, Beth Dakin 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-04-11 15:52:58 PDT 
We need WK2 API to disable rubber-banding.

<rdar://problem/15364278>
Comment 1 Beth Dakin 2014-04-11 15:57:56 PDT 
Created attachment 229171 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-04-11 16:16:10 PDT 
Comment on attachment 229171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229171&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.h:185
> +WK_EXPORT bool WKPageVerticalRubberBandingIsDisabled(WKPageRef);
> +WK_EXPORT void WKPageDisableVerticalRubberBanding(WKPageRef, bool disableVerticalRubberBanding);
> +WK_EXPORT bool WKPageHorizontalRubberBandingIsDisabled(WKPageRef);
> +WK_EXPORT void WKPageDisableHorizontalRubberBanding(WKPageRef, bool disableHorizontalRubberBanding);

It would be slightly cleaner to have the API in positive terms (enabled, not disabled) I think.

> Source/WebKit2/WebProcess/WebPage/WebPage.h:363
> +    void disableVerticalRubberBanding(bool);
> +    void disableHorizontalRubberBanding(bool);

I think setDisabled would be better terminology (or setEnabled if you want a positive term).
Comment 3 Beth Dakin 2014-04-11 16:52:55 PDT 
Thanks, Simon! I switch the the positive terminology and the 'set' language. 

http://trac.webkit.org/changeset/167172