Bug 131559 – Aggregate multiple "respondToChangedSelection" calls to one scan for telephone numbers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

Aggregate multiple "respondToChangedSelection" calls to one scan for telephone numbers

Turns out Editor::respondToChangedSelection is called a lot more often than when the user visible selection changes as the result of a user event.

In fact, it can be called many (hundreds!) of times during one iteration of the run loop.

We should aggregate all of those calls into a single telephone number scan.

[Brady Eidson]

Created attachment 229157 [details]
Patch v1

[WebKit Commit Bot]

Comment on attachment 229157 [details]
Patch v1

Clearing flags on attachment: 229157

Committed r167148: <http://trac.webkit.org/changeset/167148>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

Why don't we just do this in editorUIUpdateTimerFired instead of adding a separate timer?

[Brady Eidson]

(In reply to comment #4)
> Why don't we just do this in editorUIUpdateTimerFired instead of adding a separate timer?

I saw that there was an early return before the m_editorUIUpdateTimer was started, but knew we needed to do this work every time.

Looking at it closer now, the early return was simply a:
    if (m_editorUIUpdateTimer.isActive())
        return;
check.

I agree the existing timer should be good enough here!

(I won't be near a dev environment for a few days, in case anyone else wanted to fix this before then)