Bug 131556 - [ASan] Build broke because libCompileRuntimeToLLVMIR.a links to libclang_rt.asan_osx_dynamic.dylib
Summary: [ASan] Build broke because libCompileRuntimeToLLVMIR.a links to libclang_rt.a...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Keywords: InRadar
Depends on: 130523
  Show dependency treegraph
Reported: 2014-04-11 12:17 PDT by David Kilzer (:ddkilzer)
Modified: 2014-04-11 14:12 PDT (History)
8 users (show)

See Also:

Patch v1 (1.35 KB, patch)
2014-04-11 12:24 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-04-11 12:17:06 PDT
The fix for Bug 130523 broke ASan builds.  When building the static library, libCompileRuntimeToLLVMIR.a, we should not try to link to libclang_rt.asan_osx_dynamic.dylib.

Bug 130523: WIP for inlining C++.  Added a build target to produce LLVM IR.
Comment 1 David Kilzer (:ddkilzer) 2014-04-11 12:24:09 PDT
Created attachment 229150 [details]
Patch v1
Comment 2 Brent Fulgham 2014-04-11 13:39:53 PDT
Comment on attachment 229150 [details]
Patch v1

Looks good!  r=me
Comment 3 David Kilzer (:ddkilzer) 2014-04-11 13:41:45 PDT
Comment 4 WebKit Commit Bot 2014-04-11 14:11:56 PDT
Comment on attachment 229150 [details]
Patch v1

Clearing flags on attachment: 229150

Committed r167149: <http://trac.webkit.org/changeset/167149>
Comment 5 WebKit Commit Bot 2014-04-11 14:12:00 PDT
All reviewed patches have been landed.  Closing bug.