Bug 131545 – [GTK] Layout Test media/media-event-listeners.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

The following layout test is failing on platform GTK since it was added on r164142 <http://trac.webkit.org/r164142>

media/media-event-listeners.html

The tests usually times out, but if you run it with a high enough timeout it gives the following failure:

--- /stuff/webkit/webkit/layout-test-results/media/media-event-listeners-expected.txt
+++ /stuff/webkit/webkit/layout-test-results/media/media-event-listeners-actual.txt
@@ -1,15 +1,2 @@
+FAIL: Timed out waiting for notifyDone to be called
 
-LISTENER(durationchange)
-LISTENER(loadedmetadata)
-LISTENER(loadeddata)
-LISTENER(canplay)
-LISTENER(canplaythrough)
-LISTENER(play)
-LISTENER(playing)
-LISTENER(ratechange)
-LISTENER(timeupdate)
-LISTENER(pause)
-LISTENER(ended)
-LISTENER(volumechange)
-END OF TEST
-


I will mark the test accordingly on the expectations.

[Marcos Chavarría Teijeiro (irc: chavaone)]

This test is no longer timing out after r178418 (https://trac.webkit.org/changeset/178418). Now, it's failing. Updating expectations on bugs.webkit.org/show_bug.cgi?id=143467.

[Michael Catanzaro]

It occasionally passes fine, so I marked it as flaky.

[Diego Pino]

It seems this test was passing, although it was marked flaky. However, since r267162 the test is timing out. The failure happened in the following interval:

[r267156-r267159]             PASS (Expected: PASS FAIL)
[r267160-r267161]             UNKNOWN
r267162                       TIMEOUT (Expected: PASS FAIL)

I cannot determine the cause within the range [r267160-r267162].

The test result looks the same as the output described in https://bugs.webkit.org/show_bug.cgi?id=131545#c0

Diff: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r267333%20(15940)/media/media-event-listeners-diff.txt

--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/media-event-listeners-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/media-event-listeners-actual.txt
@@ -1,15 +1,2 @@
+FAIL: Timed out waiting for notifyDone to be called
 
-LISTENER(durationchange)
-LISTENER(loadedmetadata)
-LISTENER(loadeddata)
-LISTENER(canplay)
-LISTENER(canplaythrough)
-LISTENER(play)
-LISTENER(playing)
-LISTENER(ratechange)
-LISTENER(timeupdate)
-LISTENER(pause)
-LISTENER(ended)
-LISTENER(volumechange)
-END OF TEST
-

Update expectations accordingly.

[Lauro Moura]

It started in r267162, which changed WTR's TestController.cpp:

> - WKPageSetMuted(m_mainWebView->page(), true);
> + WKPageSetMediaVolume(m_mainWebView->page(), 0);

With this change, after setting the video source the player changes the volume from 1 to 0 before playing, which happens to cause the following 'video.volume = 0' become a NOP and the volumechange event ends up not being triggered.

[Lauro Moura]

Ditto for media/video-volume.html

[Xabier Rodríguez Calvar]

Fixed in r279499

[Radar WebKit Bug Importer]

<rdar://problem/80076065>