Bug 131540 – [GTK] Add support for text-decoration-skip

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

The following layout test is failing on platform GTK

fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-svg.html

The failure started to happen on r166902 <http://trac.webkit.org/r166902>.
I tested r166901 and the tests passes. From r166902 ahead the test fails.

The diff is:

http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r166911%20%2846234%29/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-svg-diffs.html

[Martin Robinson]

Look like we need an implementation like what was added in: https://bugs.webkit.org/show_bug.cgi?id=128936

[Martin Robinson]

Created attachment 243025 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 243025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243025&action=review

LGTM =)

> LayoutTests/platform/gtk/TestExpectations:1949
>  webkit.org/b/124507 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html [ ImageOnlyFailure ]

This was also not fixed?

[Martin Robinson]

(In reply to comment #3)
> Comment on attachment 243025 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243025&action=review
> 
> LGTM =)
> 
> > LayoutTests/platform/gtk/TestExpectations:1949
> >  webkit.org/b/124507 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html [ ImageOnlyFailure ]
> 
> This was also not fixed?

No, I think this is also a subpixel positioning issue.

[Martin Robinson]

Comment on attachment 243025 [details]
Patch

Clearing flags on attachment: 243025

Committed r177078: <http://trac.webkit.org/changeset/177078>

[Martin Robinson]

All reviewed patches have been landed.  Closing bug.