Bug 131528 – [Mac] Prevent crash when exiting fullscreen mode

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brent Fulgham]

It is possible to cause a crash in WebKit if you enter full screen mode, exit full screen mode, and close the main view quickly enough.

The crash is due to an animation thread attempting to interact with a deallocated window. When we decide to rapidly terminate a window, we need to tell any existing animation controllers to stop animating, and clear their window references.

[Brent Fulgham]

Created attachment 229107 [details]
Patch

[Brent Fulgham]

<rdar://problem/13967272>

[Jer Noble]

Comment on attachment 229107 [details]
Patch

Nice! r=me.

[Brent Fulgham]

Created attachment 229138 [details]
I think this resolves the 'real' problem

[Brent Fulgham]

It was bothering me that we were entering the WKFullScreenWindowController::close method with _fullScreenState != ExitingFullScreen, but _scaleAnimation still non-nil and running an animation.

I think the actual fix need to be done 'finishedExitFullScreenAnimation', where we clean up the _fadeAnimation, but don't touch the _scaleAnimation.

I still like the initial fix to protect us against leaving a running animation when the window is going away, but I think the 'real' fix is this second patch.

[Brent Fulgham]

Comment on attachment 229138 [details]
I think this resolves the 'real' problem

Updated patch that makes sure we never are in a state where '_fullScreenState != ExitingFullScreen' while we have a running animation.

[Jer Noble]

Comment on attachment 229138 [details]
I think this resolves the 'real' problem

re-r=me.

[Brent Fulgham]

Committed r167130: <http://trac.webkit.org/changeset/167130>