Bug 131523 – Web Inspector: Remove shared PageScriptDebugServer, create per-Page

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Having a shared PageScriptDebugServer was causing issues when we called JSC::Debugger::clearBreakpoints() and the same Debugger underlying multiple InspectorDebuggerAgent instances removed its JSC breakpoints.

By going per-Page each page will have its own JSC::Debugger/InspectorDebuggerAgent/ScriptDebugServer.

Note that PageScriptDebugServer already marks the entire page group as paused when a single Page gets paused.

[Joseph Pecoraro]

<rdar://problem/16582697>

[Joseph Pecoraro]

Created attachment 229098 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 229098 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=229098&action=review

> Source/WebCore/inspector/InspectorController.h:145
> +    PageDebuggerAgent* m_debuggerAgent;

Weird white space compared to other lines.

> Source/WebCore/inspector/PageScriptDebugServer.cppSource/WebCore/bindings/js/PageScriptDebugServer.cpp:69
> +    m_listeners.add(listener);

Odd white space here too.

[Timothy Hatcher]

(In reply to comment #3)
> (From update of attachment 229098 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=229098&action=review
> 
> > Source/WebCore/inspector/InspectorController.h:145
> > +    PageDebuggerAgent* m_debuggerAgent;
> 
> Weird white space compared to other lines.
> 
> > Source/WebCore/inspector/PageScriptDebugServer.cppSource/WebCore/bindings/js/PageScriptDebugServer.cpp:69
> > +    m_listeners.add(listener);
> 
> Odd white space here too.

I think it was just rendering weird on my phone.

[WebKit Commit Bot]

Comment on attachment 229098 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 229098

Committed r167133: <http://trac.webkit.org/changeset/167133>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.