Bug 131523 - Web Inspector: Remove shared PageScriptDebugServer, create per-Page
Summary: Web Inspector: Remove shared PageScriptDebugServer, create per-Page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-10 18:45 PDT by Joseph Pecoraro
Modified: 2014-04-11 10:48 PDT (History)
11 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (47.13 KB, patch)
2014-04-10 18:54 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-04-10 18:45:10 PDT
Having a shared PageScriptDebugServer was causing issues when we called JSC::Debugger::clearBreakpoints() and the same Debugger underlying multiple InspectorDebuggerAgent instances removed its JSC breakpoints.

By going per-Page each page will have its own JSC::Debugger/InspectorDebuggerAgent/ScriptDebugServer.

Note that PageScriptDebugServer already marks the entire page group as paused when a single Page gets paused.
Comment 1 Joseph Pecoraro 2014-04-10 18:46:41 PDT
<rdar://problem/16582697>
Comment 2 Joseph Pecoraro 2014-04-10 18:54:22 PDT
Created attachment 229098 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2014-04-10 21:40:37 PDT
Comment on attachment 229098 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=229098&action=review

> Source/WebCore/inspector/InspectorController.h:145
> +    PageDebuggerAgent* m_debuggerAgent;

Weird white space compared to other lines.

> Source/WebCore/inspector/PageScriptDebugServer.cppSource/WebCore/bindings/js/PageScriptDebugServer.cpp:69
> +    m_listeners.add(listener);

Odd white space here too.
Comment 4 Timothy Hatcher 2014-04-11 09:26:30 PDT
(In reply to comment #3)
> (From update of attachment 229098 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=229098&action=review
> 
> > Source/WebCore/inspector/InspectorController.h:145
> > +    PageDebuggerAgent* m_debuggerAgent;
> 
> Weird white space compared to other lines.
> 
> > Source/WebCore/inspector/PageScriptDebugServer.cppSource/WebCore/bindings/js/PageScriptDebugServer.cpp:69
> > +    m_listeners.add(listener);
> 
> Odd white space here too.

I think it was just rendering weird on my phone.
Comment 5 WebKit Commit Bot 2014-04-11 10:48:51 PDT
Comment on attachment 229098 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 229098

Committed r167133: <http://trac.webkit.org/changeset/167133>
Comment 6 WebKit Commit Bot 2014-04-11 10:48:56 PDT
All reviewed patches have been landed.  Closing bug.