Bug 131520 - Add user default for FTL JIT
Summary: Add user default for FTL JIT
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-10 17:56 PDT by Gavin Barraclough
Modified: 2014-05-01 13:59 PDT (History)
1 user (show)

See Also:

Attachments
Fix (5.69 KB, patch)
2014-04-10 17:59 PDT, Gavin Barraclough 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-04-10 17:56:54 PDT 
.
Comment 1 Gavin Barraclough 2014-04-10 17:59:27 PDT 
Created attachment 229095 [details]
Fix
Comment 2 Benjamin Poulain 2014-04-10 18:10:10 PDT 
Comment on attachment 229095 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=229095&action=review

Could you remove the environment variable thingy?
Did you perf test this??

> Source/WebKit2/Shared/WebProcessCreationParameters.h:141
> +    

Extra whitespace here!

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:101
> +    

ditto.

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:171
> +    

ditto.
Comment 3 Gavin Barraclough 2014-04-10 18:16:17 PDT 
Transmitting file data .....
Committed revision 167102.

D'oh, forgot review comments. :-(
Comment 4 Gavin Barraclough 2014-04-10 18:18:21 PDT 
whitespace fixed in.

Transmitting file data ...
Committed revision 167103.
Comment 5 Filip Pizlo 2014-05-01 13:49:28 PDT 
This just cost me a day of debugging.

If JSC decides to turn off the FTL JIT, then it shouldn't be possible for WK2 to turn it on.

I don't think that flipping JSC's Options directly is an appropriate way to do this.  I will roll it out with MarkH's rubber stamp.
Comment 6 Filip Pizlo 2014-05-01 13:59:23 PDT 
Rolled out in r168120.

We need to find a way of doing this that still allows JSC to disable the FTL JIT regardless of external settings.