Bug 131514 - [Win] Clean up some 64-bit Warnings from Visual Studio Static Analyzer
Summary: [Win] Clean up some 64-bit Warnings from Visual Studio Static Analyzer
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
Keywords: InRadar
Depends on:
Reported: 2014-04-10 16:36 PDT by Brent Fulgham
Modified: 2014-04-10 18:02 PDT (History)
5 users (show)

See Also:

Patch (4.16 KB, patch)
2014-04-10 16:38 PDT, Brent Fulgham
thorton: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-04-10 16:36:47 PDT
This patch makes a couple of changes needed for 64-bit support on Windows:

1. Set our Microsoft build settings against Vista for 64-bit.
2. Silence a warning about MEMORY_BASIC_INFORMATION being uninitialized.
3. Silence a warning about deprecated GetTickCount() use
Comment 1 Brent Fulgham 2014-04-10 16:38:57 PDT
Created attachment 229089 [details]
Comment 2 WebKit Commit Bot 2014-04-10 16:56:34 PDT
Comment on attachment 229089 [details]

Rejecting attachment 229089 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 229089, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5120716332597248
Comment 3 Radar WebKit Bug Importer 2014-04-10 16:59:39 PDT
Comment 4 Brent Fulgham 2014-04-10 18:02:47 PDT
Committed r167101: <http://trac.webkit.org/changeset/167101>