Bug 131513 - [iOS WebKit2]: Share NSURLCache directory for webkit processes
Summary: [iOS WebKit2]: Share NSURLCache directory for webkit processes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-10 16:23 PDT by Pratik Solanki
Modified: 2014-04-11 13:34 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.73 KB, patch)
2014-04-10 16:26 PDT, Pratik Solanki 		no flags Details | Formatted Diff | Diff
Patch (6.78 KB, patch)
2014-04-10 16:33 PDT, Pratik Solanki 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2014-04-10 16:23:53 PDT 
[iOS WebKit2]: Share NSURLCache directory for webkit processes
Comment 1 Pratik Solanki 2014-04-10 16:24:25 PDT 
<rdar://problem/16420859>
Comment 2 Pratik Solanki 2014-04-10 16:26:11 PDT 
Created attachment 229087 [details]
Patch
Comment 3 Pratik Solanki 2014-04-10 16:33:28 PDT 
Created attachment 229088 [details]
Patch
Comment 4 Alexey Proskuryakov 2014-04-10 17:23:42 PDT 
Comment on attachment 229088 [details]
Patch

I'd have put both branches in NetworkProcessCocoa.mm, matching WebProcessCocoa.mm - it's unfortunate that the code is structured differently between the two.

r=me either way.
Comment 5 Pratik Solanki 2014-04-11 10:44:25 PDT 
(In reply to comment #4)
> (From update of attachment 229088 [details])
> I'd have put both branches in NetworkProcessCocoa.mm, matching WebProcessCocoa.mm

Okay.

> - it's unfortunate that the code is structured differently between the two.

Yeah.

> r=me either way.

Thanks!
Comment 6 Pratik Solanki 2014-04-11 13:34:44 PDT 
Committed r167143: <http://trac.webkit.org/changeset/167143>