Bug 131503 - Radio buttons are using the wrong sizes and margins
Summary: Radio buttons are using the wrong sizes and margins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-10 12:00 PDT by Beth Dakin
Modified: 2022-10-05 15:40 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.81 KB, patch)
2014-04-10 15:29 PDT, Beth Dakin 		jer.noble: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-04-10 12:00:32 PDT 
This is a regression caused by http://trac.webkit.org/changeset/166514 

In making checkboxes and radio buttons share code, I accidentally used checkbox metrics in two spots for radio buttons as well. Miraculously, this does not seem to have effected the rendering is any obvious way, but we should still fix it.
Comment 1 Beth Dakin 2014-04-10 15:29:58 PDT 
Created attachment 229082 [details]
Patch
Comment 2 Jer Noble 2014-04-10 15:49:50 PDT 
Comment on attachment 229082 [details]
Patch

Because I can't not have a nit, I'd move the "const int* controlMargins" line down below the zoomedSize.setWidth and zoomedSize.setHeight lines.  But r=me. :)
Comment 3 Ahmad Saleem 2022-10-05 15:39:55 PDT 
This seems to landed and not backed out:

https://github.com/WebKit/WebKit/commit/35462e5d6da95e2a904486feba09884d4bb9cc8e

Marking as "RESOLVED FIXED". Thanks!
Comment 4 Radar WebKit Bug Importer 2022-10-05 15:40:19 PDT 
<rdar://problem/100827126>