Bug 131452 - Avoid Vector copies in RenderGrid::placeItemsOnGrid()
Summary: Avoid Vector copies in RenderGrid::placeItemsOnGrid()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-09 14:25 PDT by Zan Dobersek
Modified: 2014-04-11 10:57 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.45 KB, patch)
2014-04-09 14:27 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (3.12 KB, patch)
2014-04-10 22:55 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch for landing (4.00 KB, patch)
2014-04-11 01:31 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-04-09 14:25:26 PDT
Avoid Vector copies in RenderGrid::placeItemsOnGrid()
Comment 1 Zan Dobersek 2014-04-09 14:27:20 PDT
Created attachment 228982 [details]
Patch
Comment 2 Sergio Villar Senin 2014-04-10 00:45:07 PDT
Comment on attachment 228982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228982&action=review

> Source/WebCore/ChangeLog:9
> +        placeAutoMajorAxisItemsOnGrid() methods which take the vectors by value.

There is actually no reason to pass them by value. Let's just use references there. Actually we should use const references as the vectors are not modified at all.
Comment 3 Zan Dobersek 2014-04-10 22:55:57 PDT
Created attachment 229111 [details]
Patch
Comment 4 Sergio Villar Senin 2014-04-11 01:02:41 PDT
Comment on attachment 229111 [details]
Patch

Nice changes!

You need to modify the prototypes to fix the build though :)
Comment 5 Zan Dobersek 2014-04-11 01:31:20 PDT
Created attachment 229118 [details]
Patch for landing

Testing it againg through EWSs.
Comment 6 Zan Dobersek 2014-04-11 10:57:10 PDT
Comment on attachment 229118 [details]
Patch for landing

Clearing flags on attachment: 229118

Committed r167134: <http://trac.webkit.org/changeset/167134>
Comment 7 Zan Dobersek 2014-04-11 10:57:20 PDT
All reviewed patches have been landed.  Closing bug.