Bug 131451 - Don't offer "contact" actions in telephone number menus
Summary: Don't offer "contact" actions in telephone number menus
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-09 14:09 PDT by Brady Eidson
Modified: 2014-04-09 14:32 PDT (History)
0 users

See Also:


Attachments
Patch v1 (2.67 KB, patch)
2014-04-09 14:11 PDT, Brady Eidson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-04-09 14:09:21 PDT
Don't offer "contact" actions in telephone number menus

<rdar://problem/16556907>
Comment 1 Brady Eidson 2014-04-09 14:11:05 PDT
Created attachment 228981 [details]
Patch v1
Comment 2 Tim Horton 2014-04-09 14:14:24 PDT
Comment on attachment 228981 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=228981&action=review

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:674
> +        if ([[actionObject actionUTI] rangeOfString:@"com.apple.contact."].location == 0)

hasPrefix?

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:678
> +        if ([actionObject isKindOfClass:[getDDSeparatorActionClass() class]])

Isn't it already a Class? Why +class? Same above.
Comment 3 Tim Horton 2014-04-09 14:14:42 PDT
Comment on attachment 228981 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=228981&action=review

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:78
> +@property (readonly) NSString * actionUTI;

I think the star should touch the name (to the right).
Comment 4 Tim Horton 2014-04-09 14:15:35 PDT
Comment on attachment 228981 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=228981&action=review

>> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:78
>> +@property (readonly) NSString * actionUTI;
> 
> I think the star should touch the name (to the right).

Also I think this should be empty and the property should be on a (Details) category? or WKDetails or something I don't remember.
Comment 5 Brady Eidson 2014-04-09 14:32:21 PDT
http://trac.webkit.org/changeset/167034