Bug 131448 - HTMLCollection::updateNamedElementCach iterates over items twice
Summary: HTMLCollection::updateNamedElementCach iterates over items twice
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-09 12:27 PDT by Ryosuke Niwa
Modified: 2014-04-09 12:33 PDT (History)
6 users (show)

See Also:


Attachments
Cleanup (1.80 KB, patch)
2014-04-09 12:27 PDT, Ryosuke Niwa
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-04-09 12:27:10 PDT
HTMLCollection::updateNamedElementCach iterates over items twice
Comment 1 Ryosuke Niwa 2014-04-09 12:27:48 PDT
Created attachment 228973 [details]
Cleanup
Comment 2 Andreas Kling 2014-04-09 12:31:06 PDT
Comment on attachment 228973 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=228973&action=review

Well that was silly.

> Source/WebCore/ChangeLog:8
> +        Comptue the length first and go through the cache interface to traverse through items.

Compute
Comment 3 Ryosuke Niwa 2014-04-09 12:33:22 PDT
Committed r167028: <http://trac.webkit.org/changeset/167028>