Bug 131431 - nil should only be used for objects
Summary: nil should only be used for objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Conrad Shultz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-08 23:02 PDT by Conrad Shultz
Modified: 2014-04-08 23:31 PDT (History)
15 users (show)

See Also:


Attachments
Patch (2.30 KB, patch)
2014-04-08 23:14 PDT, Conrad Shultz
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Shultz 2014-04-08 23:02:24 PDT
-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:] should always return a BOOL.
Comment 1 Conrad Shultz 2014-04-08 23:09:35 PDT
Noticed there's a misuse of nil in -[WebViewFullScreenController setMediaElement:] too.
Comment 2 Conrad Shultz 2014-04-08 23:14:02 PDT
Created attachment 228944 [details]
Patch
Comment 3 chris fleizach 2014-04-08 23:18:34 PDT
Comment on attachment 228944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228944&action=review

> Source/WebCore/platform/mac/WebVideoFullscreenController.mm:147
> +            [player addObserver:self forKeyPath:@"rate" options:0 context:nullptr];

nullptr should probably be nil since this is an ObjC call
Comment 4 Mark Rowe (bdash) 2014-04-08 23:19:46 PDT
(In reply to comment #3)
> (From update of attachment 228944 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228944&action=review
> 
> > Source/WebCore/platform/mac/WebVideoFullscreenController.mm:147
> > +            [player addObserver:self forKeyPath:@"rate" options:0 context:nullptr];
> 
> nullptr should probably be nil since this is an ObjC call

The context: parameter is a void* though, so nullptr is correct.
Comment 5 WebKit Commit Bot 2014-04-08 23:31:51 PDT
Comment on attachment 228944 [details]
Patch

Clearing flags on attachment: 228944

Committed r167003: <http://trac.webkit.org/changeset/167003>
Comment 6 WebKit Commit Bot 2014-04-08 23:31:55 PDT
All reviewed patches have been landed.  Closing bug.