nil should only be used for objects

[Conrad Shultz]

-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:] should always return a BOOL.

[Conrad Shultz]

Noticed there's a misuse of nil in -[WebViewFullScreenController setMediaElement:] too.

[Conrad Shultz]

Created attachment 228944 [details]
Patch

[chris fleizach]

Comment on attachment 228944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228944&action=review

> Source/WebCore/platform/mac/WebVideoFullscreenController.mm:147
> +            [player addObserver:self forKeyPath:@"rate" options:0 context:nullptr];

nullptr should probably be nil since this is an ObjC call

[Mark Rowe (bdash)]

(In reply to comment #3)
> (From update of attachment 228944 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228944&action=review
> 
> > Source/WebCore/platform/mac/WebVideoFullscreenController.mm:147
> > +            [player addObserver:self forKeyPath:@"rate" options:0 context:nullptr];
> 
> nullptr should probably be nil since this is an ObjC call

The context: parameter is a void* though, so nullptr is correct.

[WebKit Commit Bot]

Comment on attachment 228944 [details]
Patch

Clearing flags on attachment: 228944

Committed r167003: <http://trac.webkit.org/changeset/167003>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.