RESOLVED FIXED 131420
Discern between NaNs that would be safe to tag and NaNs that need some purification before tagging 
https://bugs.webkit.org/show_bug.cgi?id=131420
Summary Discern between NaNs that would be safe to tag and NaNs that need some purifi...
Filip Pizlo
Reported 2014-04-08 20:18:22 PDT
...
Attachments
work in progress (37.07 KB, patch)
2014-04-15 21:22 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
almost done (65.69 KB, patch)
2014-04-16 12:09 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (71.89 KB, patch)
2014-04-16 12:44 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
patch for landing (71.89 KB, patch)
2014-04-16 15:25 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-04-15 21:22:56 PDT
Created attachment 229428 [details] work in progress
Filip Pizlo
Comment 2 2014-04-16 12:09:51 PDT
Created attachment 229463 [details] almost done
Filip Pizlo
Comment 3 2014-04-16 12:44:06 PDT
Created attachment 229465 [details] the patch
WebKit Commit Bot
Comment 4 2014-04-16 12:46:54 PDT
Attachment 229465 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSCJSValue.h:27: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/JavaScriptCore/runtime/PureNaN.h:35: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/runtime/PureNaN.h:36: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/runtime/PureNaN.h:37: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 4 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 5 2014-04-16 15:25:03 PDT
Created attachment 229487 [details] patch for landing
WebKit Commit Bot
Comment 6 2014-04-16 15:28:05 PDT
Attachment 229487 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSCJSValue.h:27: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/JavaScriptCore/runtime/PureNaN.h:35: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/runtime/PureNaN.h:36: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/runtime/PureNaN.h:37: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 4 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 7 2014-04-16 15:44:53 PDT
Landed in http://trac.webkit.org/changeset/167394
Note You need to log in before you can comment on or make changes to this bug.