Bug 131417 - Factor tile coverage map into a class
Summary: Factor tile coverage map into a class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-08 19:56 PDT by Antti Koivisto
Modified: 2014-04-08 22:02 PDT (History)
3 users (show)

See Also:


Attachments
patch (26.98 KB, patch)
2014-04-08 20:01 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
make it build on release (26.86 KB, patch)
2014-04-08 20:18 PDT, Antti Koivisto
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-04-08 19:56:00 PDT
Move the map code out from TileController
Comment 1 Antti Koivisto 2014-04-08 20:01:07 PDT
Created attachment 228927 [details]
patch
Comment 2 Antti Koivisto 2014-04-08 20:18:48 PDT
Created attachment 228928 [details]
make it build on release
Comment 3 Tim Horton 2014-04-08 21:31:40 PDT
Comment on attachment 228928 [details]
make it build on release

View in context: https://bugs.webkit.org/attachment.cgi?id=228928&action=review

> Source/WebCore/platform/graphics/ca/mac/TileCoverageMap.mm:40
> +    m_layer.get().setOpacity(0.75);

.get(). is ugly; is there a better way?
Comment 4 Simon Fraser (smfr) 2014-04-08 21:38:23 PDT
Where is the announcement/documentation about Ref?
Comment 5 Antti Koivisto 2014-04-08 21:46:19 PDT
(In reply to comment #4)
> Where is the announcement/documentation about Ref?

Andreas?
Comment 6 Antti Koivisto 2014-04-08 21:51:11 PDT
(In reply to comment #3)
> (From update of attachment 228928 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228928&action=review
> 
> > Source/WebCore/platform/graphics/ca/mac/TileCoverageMap.mm:40
> > +    m_layer.get().setOpacity(0.75);
> 
> .get(). is ugly; is there a better way?

There is -> but I think the plan is to remove it as it implies pointer semantics while Ref is supposed to have reference semantics. There is no operator.() so we end up with get().
Comment 7 Antti Koivisto 2014-04-08 22:02:49 PDT
https://trac.webkit.org/r166997