Bug 131405 – Add a WKNavigationAction property indicating whether it resulted from processing a user gesture

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Add a WKNavigationAction property indicating whether it resulted from processing a user gesture

[Anders Carlsson]

Created attachment 228905 [details]
Patch

[WebKit Commit Bot]

Attachment 228905 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h:41:  Should not have spaces around = in property attributes.  [whitespace/property] [4]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionPrivate.h:33:  Should not have spaces around = in property attributes.  [whitespace/property] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 228905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228905&action=review

> Source/WebKit2/Shared/NavigationActionData.cpp:38
> +    , modifiers()

why?

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h:41
>  @property (nonatomic, readwrite, copy, setter=_setOriginalURL:) NSURL *_originalURL;
> +@property (nonatomic, readwrite, setter = _setUserInitiated:) BOOL _userInitiated;

spaces or no spaces around the =? please choose.

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionPrivate.h:33
> +@property (nonatomic, readonly, getter = _isUserInitiated) BOOL _userInitiated;

ditto

[Anders Carlsson]

(In reply to comment #3)
> (From update of attachment 228905 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228905&action=review
> 
> > Source/WebKit2/Shared/NavigationActionData.cpp:38
> > +    , modifiers()
> 
> why?
> 

To zero-initialize modifiers.

[Anders Carlsson]

Committed r166976: <http://trac.webkit.org/changeset/166976>