Bug 131405 - Add a WKNavigationAction property indicating whether it resulted from processing a user gesture
Summary: Add a WKNavigationAction property indicating whether it resulted from process...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-08 16:03 PDT by Anders Carlsson
Modified: 2014-04-08 16:19 PDT (History)
1 user (show)

See Also:


Attachments
Patch (9.80 KB, patch)
2014-04-08 16:04 PDT, Anders Carlsson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-04-08 16:03:36 PDT
Add a WKNavigationAction property indicating whether it resulted from processing a user gesture
Comment 1 Anders Carlsson 2014-04-08 16:04:21 PDT
Created attachment 228905 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-08 16:05:53 PDT
Attachment 228905 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h:41:  Should not have spaces around = in property attributes.  [whitespace/property] [4]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionPrivate.h:33:  Should not have spaces around = in property attributes.  [whitespace/property] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-04-08 16:06:02 PDT
Comment on attachment 228905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228905&action=review

> Source/WebKit2/Shared/NavigationActionData.cpp:38
> +    , modifiers()

why?

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h:41
>  @property (nonatomic, readwrite, copy, setter=_setOriginalURL:) NSURL *_originalURL;
> +@property (nonatomic, readwrite, setter = _setUserInitiated:) BOOL _userInitiated;

spaces or no spaces around the =? please choose.

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionPrivate.h:33
> +@property (nonatomic, readonly, getter = _isUserInitiated) BOOL _userInitiated;

ditto
Comment 4 Anders Carlsson 2014-04-08 16:18:21 PDT
(In reply to comment #3)
> (From update of attachment 228905 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228905&action=review
> 
> > Source/WebKit2/Shared/NavigationActionData.cpp:38
> > +    , modifiers()
> 
> why?
> 

To zero-initialize modifiers.
Comment 5 Anders Carlsson 2014-04-08 16:19:56 PDT
Committed r166976: <http://trac.webkit.org/changeset/166976>