Bug 131401 - Change WebPageProxy::CreateNewPage to take a NavigationActionData object
Summary: Change WebPageProxy::CreateNewPage to take a NavigationActionData object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-08 15:20 PDT by Anders Carlsson
Modified: 2014-04-08 15:37 PDT (History)
0 users

See Also:


Attachments
Patch (17.16 KB, patch)
2014-04-08 15:21 PDT, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-04-08 15:20:34 PDT
Change WebPageProxy::CreateNewPage to take a NavigationActionData object
Comment 1 Anders Carlsson 2014-04-08 15:21:30 PDT
Created attachment 228899 [details]
Patch
Comment 2 mitz 2014-04-08 15:32:06 PDT
Comment on attachment 228899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228899&action=review

> Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:96
>      // FIXME: Set a real navigation type.

You can remove this now.
Comment 3 Anders Carlsson 2014-04-08 15:37:43 PDT
Committed r166969: <http://trac.webkit.org/changeset/166969>