Bug 131400 - HTMLConverter::aggregatedAttributesForAncestors should cache intermediate results
Summary: HTMLConverter::aggregatedAttributesForAncestors should cache intermediate res...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 130227
  Show dependency tree / graph
 
Reported: 2014-04-08 15:19 PDT by Ryosuke Niwa
Modified: 2014-04-08 17:06 PDT (History)
6 users (show)

See Also:

Attachments
Fixes the bug (4.20 KB, patch)
2014-04-08 15:21 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch for landing (5.67 KB, patch)
2014-04-08 16:27 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch for landing 2 (4.24 KB, patch)
2014-04-08 16:28 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-04-08 15:19:34 PDT 
Right now, aggregatedAttributesForAncestors merges attributes from each ancestor all the way up for each text node.
We should cache the intermediate results on each ancestor along the way.
Comment 1 Ryosuke Niwa 2014-04-08 15:21:58 PDT 
Created attachment 228900 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2014-04-08 16:27:45 PDT 
Created attachment 228908 [details]
Patch for landing
Comment 3 Ryosuke Niwa 2014-04-08 16:28:18 PDT 
Created attachment 228909 [details]
Patch for landing 2
Comment 4 WebKit Commit Bot 2014-04-08 17:06:36 PDT 
Comment on attachment 228909 [details]
Patch for landing 2

Clearing flags on attachment: 228909

Committed r166981: <http://trac.webkit.org/changeset/166981>
Comment 5 WebKit Commit Bot 2014-04-08 17:06:40 PDT 
All reviewed patches have been landed.  Closing bug.