Bug 131396 - Remove lock around atomic string table when web thread is enabled
Summary: Remove lock around atomic string table when web thread is enabled
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-08 14:27 PDT by Antti Koivisto
Modified: 2014-04-09 10:26 PDT (History)
5 users (show)

See Also:

Attachments
patch (185.60 KB, patch)
2014-04-08 14:56 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (4.56 KB, patch)
2014-04-08 14:57 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-04-08 14:27:20 PDT 
It is not needed anymore.
Comment 1 Antti Koivisto 2014-04-08 14:56:12 PDT 
Created attachment 228894 [details]
patch
Comment 2 Antti Koivisto 2014-04-08 14:57:02 PDT 
Created attachment 228895 [details]
patch
Comment 3 Antti Koivisto 2014-04-08 14:57:19 PDT 
<rdar://problem/6330124>
Comment 4 Benjamin Poulain 2014-04-08 14:59:11 PDT 
Comment on attachment 228895 [details]
patch

You can also remove the #include for the spin lock.
Comment 5 Antti Koivisto 2014-04-08 15:16:42 PDT 
Comment on attachment 228895 [details]
patch

Seems we can't do this yet since WebKit2 UI process side uses WebCore::ResourceRequest which uses AtomicStrings. :(
Comment 6 Benjamin Poulain 2014-04-08 15:25:45 PDT 
(In reply to comment #5)
> (From update of attachment 228895 [details])
> Seems we can't do this yet since WebKit2 UI process side uses WebCore::ResourceRequest which uses AtomicStrings. :(

The old lock does not protect that. Neither the refcount nor the flags are thread safe. The lock was a hack for a specific code path into AtomicString.