WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
131378
Remove exposedRect from TileController
https://bugs.webkit.org/show_bug.cgi?id=131378
Summary
Remove exposedRect from TileController
Antti Koivisto
Reported
2014-04-08 11:55:09 PDT
Having two separate visible rectangles is confusing. We should compute one on higher level.
Attachments
patch
(13.36 KB, patch)
2014-04-08 12:50 PDT
,
Antti Koivisto
simon.fraser
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2014-04-08 12:50:56 PDT
Created
attachment 228873
[details]
patch
Simon Fraser (smfr)
Comment 2
2014-04-08 13:19:41 PDT
Comment on
attachment 228873
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=228873&action=review
> Source/WebCore/platform/graphics/TiledBacking.h:53 > + virtual void setTiledScrollingIndicatorPosition(const FloatPoint&) = 0;
Why doesn't this happen automatically when tiles are updated? Don't we have enough data in TileController to choose a good position?
Tim Horton
Comment 3
2014-04-08 13:20:28 PDT
Comment on
attachment 228873
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=228873&action=review
> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:454 > + for (const auto& layer : m_pageOverlayLayers.values()) > + layer->flushCompositingState(m_scrolledExposedRect);
Do we want to flush these right away? Seems like we should just do this at flush time. In any case, I'm upending the overlay code in
https://bugs.webkit.org/show_bug.cgi?id=131353
so I will sort it out.
Antti Koivisto
Comment 4
2014-04-08 13:50:02 PDT
(In reply to
comment #2
)
> (From update of
attachment 228873
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=228873&action=review
> > > Source/WebCore/platform/graphics/TiledBacking.h:53 > > + virtual void setTiledScrollingIndicatorPosition(const FloatPoint&) = 0; > > Why doesn't this happen automatically when tiles are updated? Don't we have enough data in TileController to choose a good position?
I really just punted figuring it out in this patch.
Tim Horton
Comment 5
2014-04-08 16:36:55 PDT
http://trac.webkit.org/changeset/166958
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug