RESOLVED FIXED 131374
[Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is a text-type HTML input element 
https://bugs.webkit.org/show_bug.cgi?id=131374
Summary [Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is a text-ty...
mitz
Reported 2014-04-08 10:56:11 PDT
[Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is a text-type HTML input element
Attachments
Add -[WKWebProcessPlugInNodeHandle isTextField] (4.02 KB, patch)
2014-04-08 11:01 PDT, mitz 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-04-08 11:01:55 PDT
Created attachment 228856 [details] Add -[WKWebProcessPlugInNodeHandle isTextField]
Anders Carlsson
Comment 2 2014-04-08 11:03:21 PDT
Comment on attachment 228856 [details] Add -[WKWebProcessPlugInNodeHandle isTextField] View in context: https://bugs.webkit.org/attachment.cgi?id=228856&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:45 > +@property (nonatomic, readonly, getter=isTextField) BOOL textField; I think we should follow the pattern from JSValue here and make this a method named isTextField instead of a property.
mitz
Comment 3 2014-04-08 11:05:46 PDT
(In reply to comment #2) > (From update of attachment 228856 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228856&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:45 > > +@property (nonatomic, readonly, getter=isTextField) BOOL textField; > > I think we should follow the pattern from JSValue here and make this a method named isTextField instead of a property. Done. Committed <http://trac.webkti.org/r166936>.
Note You need to log in before you can comment on or make changes to this bug.