Bug 131373 - [GTK] Remove DumpRenderTree and GtkLauncher
Summary: [GTK] Remove DumpRenderTree and GtkLauncher
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks: 130899
  Show dependency treegraph
 
Reported: 2014-04-08 10:45 PDT by Martin Robinson
Modified: 2014-05-04 13:53 PDT (History)
1 user (show)

See Also:


Attachments
Patch (256.73 KB, patch)
2014-04-08 11:02 PDT, Martin Robinson
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2014-04-08 10:45:12 PDT
We no longer need these tools now that WebKit1 is being removed.
Comment 1 Martin Robinson 2014-04-08 11:02:58 PDT
Created attachment 228857 [details]
Patch
Comment 2 Martin Robinson 2014-04-08 15:52:54 PDT
Committed r166973: <http://trac.webkit.org/changeset/166973>
Comment 3 Jarek Czekalski 2014-05-04 13:47:24 PDT
Tools/Scripts/run-webkit-tests complains about missing DumpRenderTree. And I thought it's just useful to dump arbitrary html using this bin.

    DumpRenderTree was not found at /mnt/m/usr/src/webkit-trunk/WebKitBuild/Release/bin/DumpRenderTree
    Build check failed
Comment 4 Martin Robinson 2014-05-04 13:53:47 PDT
(In reply to comment #3)
> Tools/Scripts/run-webkit-tests complains about missing DumpRenderTree. And I thought it's just useful to dump arbitrary html using this bin.

Since it linked against WebKit1, it wouldn't have compiled anyhow. One thing we can do is add GTK+ support for Scripts/run-test-runner.