When opening http://acid3.acidtests.org/ in WinCairo's WinLauncher I get a "Frame load interrupted" Error dialog and then it crashes sometimes if you continue. Does anyone else have this problem? I think it might be from not cancelling something in the CURL code, but I have no idea what.
(In reply to comment #0) > When opening http://acid3.acidtests.org/ in WinCairo's WinLauncher I get a "Frame load interrupted" Error dialog and then it crashes sometimes if you continue. Does anyone else have this problem? I think it might be from not cancelling something in the CURL code, but I have no idea what. I've seen this too, on other web sites. Not sure what causes it, though.
Created attachment 231236 [details] Patch
Comment on attachment 231236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231236&action=review Nice work tracking this down! Thank you for all your help. R=me. > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:536 > + String url = job->firstRequest().url().string(); This should be a const reference to avoid making an extra copy.
Created attachment 231242 [details] Patch
(In reply to comment #3) > (From update of attachment 231236 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231236&action=review > > Nice work tracking this down! Thank you for all your help. R=me. > Thanks :) > > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:536 > > + String url = job->firstRequest().url().string(); > > This should be a const reference to avoid making an extra copy. Updated patch.
Comment on attachment 231242 [details] Patch R=me
Comment on attachment 231242 [details] Patch Clearing flags on attachment: 231242 Committed r168596: <http://trac.webkit.org/changeset/168596>
All reviewed patches have been landed. Closing bug.