Bug 131359 – [GTK] Remove WebKit1 unit tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

After r166504 we no longer run WebKit1 unit tests, so we can remove the Skipped lines for them.

[Martin Robinson]

Created attachment 228834 [details]
Patch

[Daniel Bates]

Comment on attachment 228834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228834&action=review

> Tools/ChangeLog:7
> +

For your consideration I suggest repeating or rephrasing the bug description as the description in the ChangeLog entry so as to explain the reason for these removals. Maybe something like:

Following <http://trac.webkit.org/changeset/166504> we can remove the skipped WebKit1 unit tests as we no longer run the WebKit1 unit tests by default.

I'm assuming it doesn't make sense to keep these skipped test entries even if you can explicitly run the WebKit1 unit tests.

[Martin Robinson]

(In reply to comment #2)
> (From update of attachment 228834 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228834&action=review
> 
> > Tools/ChangeLog:7
> > +
> 
> For your consideration I suggest repeating or rephrasing the bug description as the description in the ChangeLog entry so as to explain the reason for these removals. Maybe something like:
> 
> Following <http://trac.webkit.org/changeset/166504> we can remove the skipped WebKit1 unit tests as we no longer run the WebKit1 unit tests by default.

Sure. I can add the description to the ChangeLog.
 
> I'm assuming it doesn't make sense to keep these skipped test entries even if you can explicitly run the WebKit1 unit tests.

Yes, while you can still run the unit tests manually, they will soon be removed. I think the fact that they were not removed from the unit tests script is just an oversight or Carlos wanted to do it in pieces. Perhaps it does make sense to remove them from this script only while removing them completely though. I'll rework the patch.

[Carlos Garcia Campos]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 228834 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=228834&action=review
> > 
> > > Tools/ChangeLog:7
> > > +
> > 
> > For your consideration I suggest repeating or rephrasing the bug description as the description in the ChangeLog entry so as to explain the reason for these removals. Maybe something like:
> > 
> > Following <http://trac.webkit.org/changeset/166504> we can remove the skipped WebKit1 unit tests as we no longer run the WebKit1 unit tests by default.
> 
> Sure. I can add the description to the ChangeLog.
> 
> > I'm assuming it doesn't make sense to keep these skipped test entries even if you can explicitly run the WebKit1 unit tests.
> 
> Yes, while you can still run the unit tests manually, they will soon be removed. I think the fact that they were not removed from the unit tests script is just an oversight or Carlos wanted to do it in pieces. Perhaps it does make sense to remove them from this script only while removing them completely though. I'll rework the patch.

I forgot to remove the skipped tests

[Martin Robinson]

Created attachment 228842 [details]
Patch

[Martin Robinson]

Committed r166977: <http://trac.webkit.org/changeset/166977>