Bug 131339 - Web Replay: memoize nondeterministic attributes of the Screen interface
Summary: Web Replay: memoize nondeterministic attributes of the Screen interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Burg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-07 18:43 PDT by Brian Burg
Modified: 2014-04-08 17:23 PDT (History)
10 users (show)

See Also:

Attachments
the patch (6.60 KB, patch)
2014-04-08 15:45 PDT, Brian Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-04-07 18:43:44 PDT 
It seems unlikely that this can be made deterministic by saving/restoring initial main frame size. Instead we can just memoize the attribute values as script accesses them.
Comment 1 Brian Burg 2014-04-08 15:45:18 PDT 
Created attachment 228902 [details]
the patch
Comment 2 WebKit Commit Bot 2014-04-08 17:23:13 PDT 
Comment on attachment 228902 [details]
the patch

Clearing flags on attachment: 228902

Committed r166984: <http://trac.webkit.org/changeset/166984>
Comment 3 WebKit Commit Bot 2014-04-08 17:23:17 PDT 
All reviewed patches have been landed.  Closing bug.